Fix loc import#604
Merged
BillWagner merged 1 commit intodotnet:mainfrom Dec 8, 2025
Merged
Conversation
One path through the code was missed in my tests. This fixes the path where all open issues with appropriate labels were examined.
Member
Author
|
@gewarren After you approve this and we merge it, you should run Sequester on the |
IEvangelist
approved these changes
Dec 8, 2025
gewarren
approved these changes
Dec 8, 2025
| { | ||
| variables.importTriggerLabelText ?? throw new ArgumentException("The import trigger label can't be null"), | ||
| variables.importedLabelText ?? throw new ArgumentException("The imported label can't be null") | ||
| variables.importedLabelText ?? throw new ArgumentException("The imported label can't be null"), |
Contributor
There was a problem hiding this comment.
Nit: Should we use the helper ArgumentException.ThrowIfNullOrEmpty instead? (example)
Member
Author
There was a problem hiding this comment.
Ordinarily, yet. But, this is in an expression context and that's a statement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One path through the code was missed in my tests. This fixes the path where all open issues with appropriate labels were examined.